Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Public contract registry
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
TO
Public contract registry
Commits
954380ee
Commit
954380ee
authored
1 year ago
by
Tomáš Valenta
Browse files
Options
Downloads
Patches
Plain Diff
fix signee validation
parent
08b85d70
No related branches found
No related tags found
No related merge requests found
Pipeline
#16749
passed
1 year ago
Stage: build
Stage: test_deploy
Changes
3
Pipelines
2
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
contracts/admin.py
+8
-2
8 additions, 2 deletions
contracts/admin.py
contracts/forms.py
+45
-3
45 additions, 3 deletions
contracts/forms.py
contracts/management/commands/import_old_contracts.py
+1
-2
1 addition, 2 deletions
contracts/management/commands/import_old_contracts.py
with
54 additions
and
7 deletions
contracts/admin.py
+
8
−
2
View file @
954380ee
...
...
@@ -18,10 +18,10 @@ from rangefilter.filters import DateRangeFilter
from
shared.admin
import
FieldsetInlineOrder
,
MarkdownxGuardedModelAdmin
from
.forms
import
(
AtLeastOneRequiredInlineFormSet
,
ContractAdminForm
,
ContractFileAdminForm
,
SigneeAdminForm
,
SingnatureRepresentativeFormSet
,
)
from
.models
import
(
Contract
,
...
...
@@ -124,7 +124,13 @@ class ContractFileAdmin(
class
ContracteeSignatureRepresentativeInline
(
NestedStackedInline
):
model
=
ContracteeSignatureRepresentative
extra
=
1
formset
=
AtLeastOneRequiredInlineFormSet
formset
=
SingnatureRepresentativeFormSet
def
get_formset
(
self
,
request
,
obj
=
None
,
**
kwargs
):
formset
=
super
().
get_formset
(
request
,
obj
,
**
kwargs
)
formset
.
request
=
request
return
formset
class
ContracteeSignatureInline
(
NestedStackedInline
):
...
...
This diff is collapsed.
Click to expand it.
contracts/forms.py
+
45
−
3
View file @
954380ee
...
...
@@ -6,7 +6,13 @@ from webpack_loader.loader import WebpackLoader
from
.models
import
Contract
,
ContracteeSignature
,
SigneeSignature
class
AtLeastOneRequiredInlineFormSet
(
BaseInlineFormSet
):
class
SingnatureRepresentativeFormSet
(
BaseInlineFormSet
):
def
_construct_form
(
self
,
i
,
**
kwargs
):
form
=
super
().
_construct_form
(
i
,
**
kwargs
)
form
.
request
=
self
.
request
return
form
def
clean
(
self
):
"""
Check that at least one item has been entered.
"""
...
...
@@ -15,9 +21,45 @@ class AtLeastOneRequiredInlineFormSet(BaseInlineFormSet):
if
any
(
self
.
errors
):
return
signature_position
=
None
signature_id
=
None
excluded_from_check
=
False
for
form
in
self
.
forms
:
for
key
,
value
in
form
.
request
.
POST
.
items
():
attempted_signature_position
=
key
.
replace
(
"
contractee_signatures-
"
,
""
).
replace
(
"
-id
"
,
""
)
if
(
attempted_signature_position
.
isnumeric
()
and
key
.
startswith
(
"
contractee_signatures-
"
)
and
key
.
endswith
(
"
-id
"
)
):
signature_position
=
int
(
attempted_signature_position
)
signature_id
=
int
(
value
)
if
signature_id
is
None
or
signature_id
is
None
:
break
signature
=
form
.
cleaned_data
.
get
(
"
signature
"
)
if
signature
is
not
None
:
if
(
signature
.
id
==
signature_id
and
form
.
request
.
POST
.
get
(
f
"
contractee_signatures-
{
signature_position
}
-DELETE
"
)
==
"
on
"
):
excluded_from_check
=
True
if
excluded_from_check
:
return
if
not
any
(
cleaned_data
and
not
cleaned_data
.
get
(
"
DELETE
"
,
False
)
for
cleaned_data
in
self
.
cleaned_data
form
.
cleaned_data
and
not
form
.
cleaned_data
.
get
(
"
DELETE
"
,
False
)
for
form
in
self
.
forms
):
raise
forms
.
ValidationError
(
"
Vyžadován aspoň jeden záznam.
"
)
...
...
This diff is collapsed.
Click to expand it.
contracts/management/commands/import_old_contracts.py
+
1
−
2
View file @
954380ee
...
...
@@ -10,9 +10,8 @@ from django.conf import settings
from
django.core.files
import
File
from
django.core.management.base
import
BaseCommand
from
django.db
import
models
from
postal.parser
import
parse_address
from
git
import
Repo
from
postal.parser
import
parse_address
from
...models
import
(
Contract
,
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment