From 1c4170a1f290fecdf65d04e7f3566db7c8b42dd1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Bedna=C5=99=C3=ADk?= <jan.bednarik@gmail.com> Date: Wed, 17 Feb 2021 19:45:18 +0100 Subject: [PATCH] Urlencode strings for sharing --- district/templates/district/district_article_page.html | 4 ++-- donate/templates/donate/donate_info_page.html | 6 +++--- donate/templates/donate/donate_project_page.html | 6 +++--- donate/templates/donate/donate_region_page.html | 6 +++--- .../templates/senat_campaign/senat_campaign_news_page.html | 6 +++--- .../senat_campaign/senat_campaign_program_page.html | 6 +++--- shared/templates/shared/article_preview.html | 4 ++-- shared/templates/styleguide/2.3.x/article_card.html | 4 ++-- 8 files changed, 21 insertions(+), 21 deletions(-) diff --git a/district/templates/district/district_article_page.html b/district/templates/district/district_article_page.html index 3fb3e61d..a02c4056 100644 --- a/district/templates/district/district_article_page.html +++ b/district/templates/district/district_article_page.html @@ -53,12 +53,12 @@ <span class="head-alt-base md:head-alt-md">Sdílení je aktem lásky</span> <div class="flex w-full space-x-4 pt-4 md:pt-8 text-center text-white"> <a - href="https://www.facebook.com/sharer/sharer.php?u={{ page.url }}" + href="https://www.facebook.com/sharer/sharer.php?u={{ page.full_url|urlencode }}" onclick="window.open(this.href, 'pop-up', 'left=20,top=20,width=500,height=500,toolbar=1,resizable=0'); return false;" class="bg-brands-facebook px-8 py-3 text-2xl w-full" ><i class="ico--facebook"></i></a> <a - href="https://twitter.com/intent/tweet?text={{ page.title }}&url={{ page.url }}" + href="https://twitter.com/intent/tweet?text={{ page.title|urlencode }}&url={{ page.full_url|urlencode }}" onclick="window.open(this.href, 'pop-up', 'left=20,top=20,width=500,height=500,toolbar=1,resizable=0'); return false;" class="bg-brands-twitter px-8 py-3 text-2xl w-full" ><i class="ico--twitter"></i></a> diff --git a/donate/templates/donate/donate_info_page.html b/donate/templates/donate/donate_info_page.html index 2b27b357..b3267250 100644 --- a/donate/templates/donate/donate_info_page.html +++ b/donate/templates/donate/donate_info_page.html @@ -96,9 +96,9 @@ <div class="text"><h3 class="lead">Sdílení je aktem lásky</h3></div> </div> <div class="sharing-buttons"> - <a href="https://www.facebook.com/sharer/sharer.php?u={{ page.full_url }}" target="_blank" class="btn btn-facebook"><i class="icon-facebook-f"></i></a> - <a href="https://twitter.com/intent/tweet?text=Podpoř projekt {{ page.title }}&url={{ page.full_url }}" target="_blank" class="btn btn-twitter"><i class="icon-twitter"></i></a> - <a href="https://www.linkedin.com/sharing/share-offsite/?url={{ page.full_url }}" target="_blank" class="btn btn-linkedin"><i class="icon-linkedin"></i></a> + <a href="https://www.facebook.com/sharer/sharer.php?u={{ page.full_url|urlencode }}" target="_blank" class="btn btn-facebook"><i class="icon-facebook-f"></i></a> + <a href="https://twitter.com/intent/tweet?text=Podpoř projekt {{ page.title|urlencode }}&url={{ page.full_url|urlencode }}" target="_blank" class="btn btn-twitter"><i class="icon-twitter"></i></a> + <a href="https://www.linkedin.com/sharing/share-offsite/?url={{ page.full_url|urlencode }}" target="_blank" class="btn btn-linkedin"><i class="icon-linkedin"></i></a> </div> </div> <div class="image"><img data-src="{% static "donate/img/vlajka.jpg" %}" class="img-fluid lazyload" alt="Vlajka pirátů"></div> diff --git a/donate/templates/donate/donate_project_page.html b/donate/templates/donate/donate_project_page.html index 3b44ee88..f5bc2bfc 100644 --- a/donate/templates/donate/donate_project_page.html +++ b/donate/templates/donate/donate_project_page.html @@ -130,9 +130,9 @@ <div class="text"><h3 class="lead">Sdílení je aktem lásky</h3></div> </div> <div class="sharing-buttons"> - <a href="https://www.facebook.com/sharer/sharer.php?u={{ page.full_url }}" target="_blank" class="btn btn-facebook"><i class="icon-facebook-f"></i></a> - <a href="https://twitter.com/intent/tweet?text=Podpoř projekt {{ page.title }}&url={{ page.full_url }}" target="_blank" class="btn btn-twitter"><i class="icon-twitter"></i></a> - <a href="https://www.linkedin.com/sharing/share-offsite/?url={{ page.full_url }}" target="_blank" class="btn btn-linkedin"><i class="icon-linkedin"></i></a> + <a href="https://www.facebook.com/sharer/sharer.php?u={{ page.full_url|urlencode }}" target="_blank" class="btn btn-facebook"><i class="icon-facebook-f"></i></a> + <a href="https://twitter.com/intent/tweet?text=Podpoř projekt {{ page.title|urlencode }}&url={{ page.full_url|urlencode }}" target="_blank" class="btn btn-twitter"><i class="icon-twitter"></i></a> + <a href="https://www.linkedin.com/sharing/share-offsite/?url={{ page.full_url|urlencode }}" target="_blank" class="btn btn-linkedin"><i class="icon-linkedin"></i></a> </div> </div> <div class="image"><img data-src="{% static "donate/img/vlajka.jpg" %}" class="img-fluid lazyload" alt="Vlajka pirátů"></div> diff --git a/donate/templates/donate/donate_region_page.html b/donate/templates/donate/donate_region_page.html index 9549d5c1..57243946 100644 --- a/donate/templates/donate/donate_region_page.html +++ b/donate/templates/donate/donate_region_page.html @@ -86,9 +86,9 @@ <div class="text"><h3 class="lead">Sdílení je aktem lásky</h3></div> </div> <div class="sharing-buttons"> - <a href="https://www.facebook.com/sharer/sharer.php?u={{ page.full_url }}" target="_blank" class="btn btn-facebook"><i class="icon-facebook-f"></i></a> - <a href="https://twitter.com/intent/tweet?text={{ page.main_title }}&url={{ page.full_url }}" target="_blank" class="btn btn-twitter"><i class="icon-twitter"></i></a> - <a href="https://www.linkedin.com/sharing/share-offsite/?url={{ page.full_url }}" target="_blank" class="btn btn-linkedin"><i class="icon-linkedin"></i></a> + <a href="https://www.facebook.com/sharer/sharer.php?u={{ page.full_url|urlencode }}" target="_blank" class="btn btn-facebook"><i class="icon-facebook-f"></i></a> + <a href="https://twitter.com/intent/tweet?text={{ page.main_title|urlencode }}&url={{ page.full_url|urlencode }}" target="_blank" class="btn btn-twitter"><i class="icon-twitter"></i></a> + <a href="https://www.linkedin.com/sharing/share-offsite/?url={{ page.full_url|urlencode }}" target="_blank" class="btn btn-linkedin"><i class="icon-linkedin"></i></a> </div> </div> <div class="image"><img data-src="{% static "donate/img/vlajka.jpg" %}" class="img-fluid lazyload" alt="Vlajka pirátů"></div> diff --git a/senat_campaign/templates/senat_campaign/senat_campaign_news_page.html b/senat_campaign/templates/senat_campaign/senat_campaign_news_page.html index ce4c3e10..289a59b8 100644 --- a/senat_campaign/templates/senat_campaign/senat_campaign_news_page.html +++ b/senat_campaign/templates/senat_campaign/senat_campaign_news_page.html @@ -46,9 +46,9 @@ <div class="text"><h3 class="lead">Sdílení je aktem lásky</h3></div> </div> <div class="sharing-buttons"> - <a href="https://www.facebook.com/sharer/sharer.php?u={{ page.full_url }}" target="_blank" class="btn btn-facebook"><i class="icon-facebook-f"></i></a> - <a href="https://twitter.com/intent/tweet?text={{ page.title }}&url={{ page.full_url }}" target="_blank" class="btn btn-twitter"><i class="icon-twitter"></i></a> - <a href="https://www.linkedin.com/sharing/share-offsite/?url={{ page.full_url }}" target="_blank" class="btn btn-linkedin"><i class="icon-linkedin"></i></a> + <a href="https://www.facebook.com/sharer/sharer.php?u={{ page.full_url|urlencode }}" target="_blank" class="btn btn-facebook"><i class="icon-facebook-f"></i></a> + <a href="https://twitter.com/intent/tweet?text={{ page.title|urlencode }}&url={{ page.full_url|urlencode }}" target="_blank" class="btn btn-twitter"><i class="icon-twitter"></i></a> + <a href="https://www.linkedin.com/sharing/share-offsite/?url={{ page.full_url|urlencode }}" target="_blank" class="btn btn-linkedin"><i class="icon-linkedin"></i></a> </div> </div> <div class="image"><img data-src="{% static "senat_campaign/img/vlajka.jpg" %}" class="img-fluid lazyload" alt="Vlajka pirátů"></div> diff --git a/senat_campaign/templates/senat_campaign/senat_campaign_program_page.html b/senat_campaign/templates/senat_campaign/senat_campaign_program_page.html index 070de997..54f056cf 100644 --- a/senat_campaign/templates/senat_campaign/senat_campaign_program_page.html +++ b/senat_campaign/templates/senat_campaign/senat_campaign_program_page.html @@ -35,9 +35,9 @@ <div class="text"><h3 class="lead">Sdílení je aktem lásky</h3></div> </div> <div class="sharing-buttons"> - <a href="https://www.facebook.com/sharer/sharer.php?u={{ page.root_page.full_url }}" target="_blank" class="btn btn-facebook"><i class="icon-facebook-f"></i></a> - <a href="https://twitter.com/intent/tweet?text={{ page.root_page.full_name }} - {{ page.root_page.headline }}&url={{ page.root_page.full_url }}" target="_blank" class="btn btn-twitter"><i class="icon-twitter"></i></a> - <a href="https://www.linkedin.com/sharing/share-offsite/?url={{ page.root_page.full_url }}" target="_blank" class="btn btn-linkedin"><i class="icon-linkedin"></i></a> + <a href="https://www.facebook.com/sharer/sharer.php?u={{ page.root_page.full_url|urlencode }}" target="_blank" class="btn btn-facebook"><i class="icon-facebook-f"></i></a> + <a href="https://twitter.com/intent/tweet?text={{ page.root_page.full_name|urlencode }} - {{ page.root_page.headline|urlencode }}&url={{ page.root_page.full_url|urlencode }}" target="_blank" class="btn btn-twitter"><i class="icon-twitter"></i></a> + <a href="https://www.linkedin.com/sharing/share-offsite/?url={{ page.root_page.full_url|urlencode }}" target="_blank" class="btn btn-linkedin"><i class="icon-linkedin"></i></a> </div> </div> <div class="image"><img data-src="{% static "senat_campaign/img/vlajka.jpg" %}" class="img-fluid lazyload" alt="Vlajka pirátů"></div> diff --git a/shared/templates/shared/article_preview.html b/shared/templates/shared/article_preview.html index e2b4521c..953dbc43 100644 --- a/shared/templates/shared/article_preview.html +++ b/shared/templates/shared/article_preview.html @@ -15,12 +15,12 @@ <div class="article-card-sharing"> <div class="social-icon-group"> <a - href="https://www.facebook.com/sharer/sharer.php?u={{ article.url }}" + href="https://www.facebook.com/sharer/sharer.php?u={{ article.url|urlencode }}" onclick="window.open(this.href, 'pop-up', 'left=20,top=20,width=500,height=500,toolbar=1,resizable=0'); return false;" class="social-icon social-icon--fill bg-brands-facebook text-white text-sm social-icon--4" ><i class="ico--facebook"></i></a> <a - href="https://twitter.com/intent/tweet?text={{ article.title }}&url={{ article.url }}" + href="https://twitter.com/intent/tweet?text={{ article.title|urlencode }}&url={{ article.url|urlencode }}" onclick="window.open(this.href, 'pop-up', 'left=20,top=20,width=500,height=500,toolbar=1,resizable=0'); return false;" class="social-icon social-icon--fill bg-brands-twitter text-white text-sm social-icon--4" ><i class="ico--twitter"></i></a> diff --git a/shared/templates/styleguide/2.3.x/article_card.html b/shared/templates/styleguide/2.3.x/article_card.html index 0759bab0..d5b91089 100644 --- a/shared/templates/styleguide/2.3.x/article_card.html +++ b/shared/templates/styleguide/2.3.x/article_card.html @@ -13,12 +13,12 @@ <div class="article-card-sharing"> <div class="social-icon-group "> <a - href="https://www.facebook.com/sharer/sharer.php?u={% pageurl article %}" + href="https://www.facebook.com/sharer/sharer.php?u={{ article.full_url|urlencode }}" onclick="window.open(this.href, 'pop-up', 'left=20,top=20,width=500,height=500,toolbar=1,resizable=0'); return false;" class="social-icon social-icon--fill bg-brands-facebook text-white text-sm social-icon--4" ><i class="ico--facebook"></i></a> <a - href="https://twitter.com/intent/tweet?text={{ article.title }}&url={% pageurl article %}" + href="https://twitter.com/intent/tweet?text={{ article.title|urlencode }}&url={{ article.full_url|urlencode }}" onclick="window.open(this.href, 'pop-up', 'left=20,top=20,width=500,height=500,toolbar=1,resizable=0'); return false;" class="social-icon social-icon--fill bg-brands-twitter text-white text-sm social-icon--4" ><i class="ico--twitter"></i></a> -- GitLab