From 9004a89b1b0d96921f06beb571e5c072dcd9db87 Mon Sep 17 00:00:00 2001 From: xaralis <filip.varecha@fragaria.cz> Date: Fri, 8 Jan 2021 18:32:44 +0100 Subject: [PATCH] feat: use form onSubmit over button clicks --- .env | 2 +- src/api.js | 1 + src/containers/AddAnnouncementForm.jsx | 8 +++++--- src/containers/AddPostForm.jsx | 8 +++++--- 4 files changed, 12 insertions(+), 7 deletions(-) diff --git a/.env b/.env index 8b3dabc..5285b06 100644 --- a/.env +++ b/.env @@ -1,4 +1,4 @@ REACT_APP_STYLEGUIDE_URL=https://styleguide.pir-test.eu/2.3.3 -REACT_APP_API_BASE_URL=https://cf2021.pir-test.eu/api +REACT_APP_API_BASE_URL=https://cf2021.pirati.cz/api REACT_APP_MATOMO_ID=135 REACT_APP_SENTRY_DSN=https://aa80453ff4d54b9a9c1b49e79060498a@sentry.pir-test.eu/14 diff --git a/src/api.js b/src/api.js index 8bfc444..f5b10cf 100644 --- a/src/api.js +++ b/src/api.js @@ -20,6 +20,7 @@ export const fetch = async ( body, method, headers, + redirect: "follow", }); if (!!expectedStatus && response.status !== expectedStatus) { diff --git a/src/containers/AddAnnouncementForm.jsx b/src/containers/AddAnnouncementForm.jsx index 37bd252..2b7bf5a 100644 --- a/src/containers/AddAnnouncementForm.jsx +++ b/src/containers/AddAnnouncementForm.jsx @@ -46,6 +46,8 @@ const AddAnnouncementForm = ({ className }) => { }; const onAdd = async (evt) => { + evt.preventDefault(); + let preventAction = false; const payload = { content: text, @@ -82,7 +84,7 @@ const AddAnnouncementForm = ({ className }) => { }; return ( - <div className={className}> + <form className={className} onSubmit={onAdd}> {addingError && ( <ErrorMessage> Při přidávánà oznámenà došlo k problému: {addingError}. @@ -150,7 +152,7 @@ const AddAnnouncementForm = ({ className }) => { </div> <Button - onClick={onAdd} + type="submit" className="text-sm mt-4" hoverActive loading={adding} @@ -159,7 +161,7 @@ const AddAnnouncementForm = ({ className }) => { > Přidat oznámenà </Button> - </div> + </form> ); }; diff --git a/src/containers/AddPostForm.jsx b/src/containers/AddPostForm.jsx index 0503b95..42fcf79 100644 --- a/src/containers/AddPostForm.jsx +++ b/src/containers/AddPostForm.jsx @@ -74,6 +74,8 @@ const AddPostForm = ({ className, canAddProposal }) => { }; const onAdd = async (evt) => { + evt.preventDefault(); + if (!!text) { if (!error) { const result = await (type === "post" ? addPost : addProposal).run({ @@ -125,7 +127,7 @@ const AddPostForm = ({ className, canAddProposal }) => { "p-4 lg:p-8 " + (showAddConfirm || !expanded ? "hidden" : "") } > - <div className="space-y-4"> + <form className="space-y-4" onSubmit={onAdd}> {apiError && is429ApiError && ( <div className="alert alert--warning"> <i className="alert__icon ico--clock text-lg" /> @@ -203,7 +205,7 @@ const AddPostForm = ({ className, canAddProposal }) => { <div className="space-x-4"> <Button - onClick={onAdd} + type="submit" disabled={error || addingPost || addingProposal} loading={addingPost || addingProposal} fullwidth @@ -227,7 +229,7 @@ const AddPostForm = ({ className, canAddProposal }) => { . </span> </div> - </div> + </form> </CardBody> </Card> ); -- GitLab